[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdepim/kpilot
From:       Adriaan de Groot <groot () kde ! org>
Date:       2005-04-18 22:02:39
Message-ID: 20050418220239.42C833C8 () office ! kde ! org
[Download RAW message or body]

CVS commit by adridg: 

Shuffling around


  M +5 -0      ChangeLog   1.255
  M +1 -1      kpilot/internalEditorAction.cc   1.19
  M +4 -4      lib/pilotLocalDatabase.cc   1.44
  M +8 -2      lib/pilotLocalDatabase.h   1.36


--- kdepim/kpilot/kpilot/internalEditorAction.cc  #1.18:1.19
@@ -140,5 +140,5 @@ void InternalEditorAction::syncDirtyDB()
 #endif
                         //localDB->writeRecord(rec);
-                        localDB->writeID(rec);
+                        localDB->updateID(id);
                 }
                 KPILOT_DELETE(rec);

--- kdepim/kpilot/ChangeLog  #1.254:1.255
@@ -2,4 +2,9 @@
 ======================
 
+2005-04-18  Adriaan de Groot
+* Being on vacation doesn't mean I'm not on the job. Doxied a lot, did some cleanup.
+* Renamed PilotLocalDatabase::writeID() and changed its signature, since it
+  was kind of stupid. Doxied it, too.
+
 2005-04-12  Adriaan de Groot
 * For a lark, and for David, re-added some KDE 3.2 compatibility code.

--- kdepim/kpilot/lib/pilotLocalDatabase.cc  #1.43:1.44
@@ -478,5 +478,5 @@ PilotRecord *PilotLocalDatabase::readNex
 
 // Writes a new ID to the record specified the index.  Not supported on Serial connections
-recordid_t PilotLocalDatabase::writeID(PilotRecord * rec)
+recordid_t PilotLocalDatabase::updateID(recordid_t id)
 {
         FUNCTIONSETUP;
@@ -493,7 +493,7 @@ recordid_t PilotLocalDatabase::writeID(P
                 return 0;
         }
-        fRecords[fPendingRec]->setID(rec->id());
+        fRecords[fPendingRec]->setID(id);
         fPendingRec = -1;
-        return rec->id();
+        return id;
 }
 

--- kdepim/kpilot/lib/pilotLocalDatabase.h  #1.35:1.36
@@ -126,6 +126,12 @@ public:
 
 
-        // Writes a new ID to the record specified.
-        virtual recordid_t writeID(PilotRecord* rec);
+        /** Update the ID of the current record in the database with
+        * the specified @param id . This is allowed only after
+        * reading or writing a modified or new record.
+        */
+        virtual recordid_t  updateID(recordid_t id);
+
+
+        /** Return the name of the database (as it would be on the handheld). */
         QString getDBName() const { return fDBName; }
 


[prev in list] [next in list] [prev in thread] [next in thread]