[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kicker/taskbar
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2005-04-17 23:26:13
Message-ID: 20050417232613.600905FA () office ! kde ! org
[Download RAW message or body]

CVS commit by aseigo: 

fix several crashes:

don't use a singleshot timer for mouse over triggering because we want
to stop it if the taskcontainer becomes empty

between the time a taskcontainer is created and it actually shows up, esp
if it is a startup container, the task may actually be deleted out from
under us and we may also be reGroup()'d. this combination of events can
result in taskcontainers that have references to tasks/startups that no
longer are around. we now keep track of these not-yet-shown taskcontainers

i'm not convinced that the whole design of having pointers to tasks and
startups in the taskmanager and then sharing them all over the place only
to have the taskmanager signal deletion then actually delete them is a good
idea for something as dynamic as a taskbar application =/

in any case, it should not be crashy anymore.

minor optimization: don't even bother trying to group start up
notifications. it never worked anyways (couldn't, actually, the way it was
written =). i don't see this as a bad thing, so let's not waste cycles on
it


  M +27 -28    taskbar.cpp   1.83
  M +1 -0      taskbar.h   1.43
  M +38 -30    taskcontainer.cpp   1.123
  M +1 -0      taskcontainer.h   1.44



[prev in list] [next in list] [prev in thread] [next in thread]