[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kcontrol/kfontinst/kfontinst
From:       Craig Drummond <craig () kde ! org>
Date:       2005-04-09 20:39:18
Message-ID: 20050409203918.E69BF492 () office ! kde ! org
[Download RAW message or body]

CVS commit by craig: 

Remove silly fprintf debug that was accidentaly commited! The debug writes to
/tmp/kfi - however, if root has run kfontinst, then /tmp/kfi will have been
created as root, and when a non-root user runs kfontinst it cant open this file
for writing, but no check is made before the fprintf, and hence a segmentation fault!


  M +1 -7      Main.cpp   1.13


--- kdebase/kcontrol/kfontinst/kfontinst/Main.cpp  #1.12:1.13
@@ -250,6 +250,4 @@ int main(int argc, char *argv[])
     bool folderRequired=doX || addToX || addToFc || (!root && doGs);
 
-FILE *f=fopen("/tmp/kfi", "a");
-fprintf(f, "%s\n", "Called...");
     if (left>1 || (0==left && folderRequired) || (!doX && !doGs && !addToX && !addToFc))
         usage(argv[0]);
@@ -321,8 +319,5 @@ fprintf(f, "%s\n", "Called...");
 
                 if(0==rv && doX)
-{
-fprintf(f, "%s\n", "doing X");
                     rv=KFI::CXConfig::configureDir(folder, fe) ? 0 : -5;
-}
 
                 refresh(refreshX, refreshXfs, root);
@@ -336,5 +331,4 @@ fprintf(f, "%s\n", "doing X");
     }
 
-fclose(f);
     return rv;
 }


[prev in list] [next in list] [prev in thread] [next in thread]