[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_4_BRANCH: kdepim/kmail
From:       Marc Mutz <marc () klaralvdalens-datakonsult ! se>
Date:       2005-04-09 14:45:37
Message-ID: 200504091645.39535.marc () klaralvdalens-datakonsult ! se
[Download RAW message or body]

On Saturday 09 April 2005 15:09, Andreas Gungl wrote:
> Marc, feel free to improve the source code.

Sorry, but that is _your_ job. _You_ committed a ridiculous piece of code, 
please fix it. QString("Foo").upper() is so absolutely non-sensical, everyone 
will stumble over this wondering what it is supposed to mean when reading the 
code.

> My admittedly ugly hack is a workaround to fix the problems people have
> after upgrading to KMail 1.8 - and I tried to avoid changing strings all
> around in the sources so far.

Still doesn't make sense. The string freeze is for i18n'ed strings. There's 
absolutely no need for preserving strings that are not i18n'ed. And this 
doesn't explain why you comitted the same code to HEAD, where the 
preservation of strings isn't mandated at all.

Marc

-- 
Marc Mutz -- marc@klaralvdalens-datakonsult.se, mutz@kde.org
phone: +49 521 521 45 45; mobile: +49 177 32 94 700
Klarälvdalens Datakonsult AB, Platform-independent software solutions


[prev in list] [next in list] [prev in thread] [next in thread]