Am Freitag, 8. April 2005 18:09 schrieb Stephan Kulow: > Am Freitag 08 April 2005 16:16 schrieb Tobias Anton: > > > > Shall I commit the patch attached to my previous mail? > > Does it fix anything? No. It fixes bad coding style that leads to decreased readability, thus hampering changeability. The fact that you actively hamper changes with sw quality in mind makes your point of view comprehensible but does not validate it in any way for this case. > Does it break something? Yes, either intendation or cvs annotate. CVS annotate is horribly broken, and the "breakage" does neigher affect the source code nor the software's behaviour. So: No, objectively it does not break anything. Your considerations are biased personally and do not contain any single objective argument, so please stop advocating for stagnancy. -- Tobias