From kde-commits Fri Apr 08 16:28:53 2005 From: Lubos Lunak Date: Fri, 08 Apr 2005 16:28:53 +0000 To: kde-commits Subject: Re: kdelibs/khtml Message-Id: <200504081828.54078.l.lunak () suse ! cz> X-MARC-Message: https://marc.info/?l=kde-commits&m=111297774315464 On Friday 08 of April 2005 16:16, Tobias Anton wrote: > Am Freitag, 8. April 2005 14:56 schrieb Lubos Lunak: > > > Comparing your backward goto to a loop, I don't see any advantage of > > > the backward goto. The main disadvantage of the backward goto: The exit > > > condition is not clear, whereas a loop would make it clear. > > > > Maybe if the code was written with a loop in mind, but the JPEG loader > > is written as linear code that just needs to go back in one place. I even > > tried to make it a loop first, but after getting it wrong two times I > > simply gave up (I did the mistake of trying to use a flag to bail out > > instead of the other way around, and that was pretty non-trivial). > > When looking at the source, I think that my patch is equivalent to yours. > But since I have no test case and no testing environment ready, I sticked > to commenting only. Sorry for criticizing your coding style in general - it > should have addressed the backward goto only. > > Shall I commit the patch attached to my previous mail? The patch is technically correct, and that would have been the patch I'd have committed if I did try to solve the loop the other way around. I don't mind if you commit. It's not an often modified file anyway. -- Lubos Lunak KDE developer --------------------------------------------------------------------- SuSE CR, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Drahobejlova 27 tel: +420 2 9654 2373 190 00 Praha 9 fax: +420 2 9654 2374 Czech Republic http://www.suse.cz/