[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml
From:       Allan Sandfeld Jensen <kde () carewolf ! com>
Date:       2005-04-05 22:06:01
Message-ID: 200504060006.02072.kde () carewolf ! com
[Download RAW message or body]

On Sunday 03 April 2005 20:36, you wrote:
> On Sunday 03 April 2005 18:24, Allan Sandfeld Jensen wrote:
> > CVS commit by carewolf:
> >
> > Implement frame.contentWindow and window.frameElement.
>
> Cool. contentWindow looks fine, but are you sure about frameElement?
> return retrieve(m_frame->m_part) returns a Window object, not an HTML
> <frame> element. Isn't that what frameElement should return? (I didn't look
> it up though).

Okay, what bothers me is this line
    return Window::retrieve(frame);
in
    FrameArray::get()

Isn't that also supposed to return a frame?

And if frames() doesn't contain a list of frames, but a list of windows, how 
am I supposed to get a list of frames?

`Allan
[prev in list] [next in list] [prev in thread] [next in thread]