[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/libkonq
From:       Christian Loose <christian.loose () hamburg ! de>
Date:       2005-04-05 19:43:27
Message-ID: 200504052143.28052.christian.loose () hamburg ! de
[Download RAW message or body]

Am Dienstag, 5. April 2005 00:27 schrieb Stephan Binner:
> CVS commit by binner:
>
> Bug 100597: SVG images don't have 'set as wallpaper' entry in context menu
> when dragged to desktop
>
>
>   M +3 -2      konq_operations.cc   1.163
>
>
> --- kdebase/libkonq/konq_operations.cc  #1.162:1.163
> @@ -539,6 +539,7 @@ void KonqOperations::doFileCopy()
>              (lst.count() == 1) &&
>              ((!KImageIO::type(lst.first().path()).isEmpty()) ||
> -            
> (KImageIO::isSupported(KMimeType::findByURL(lst.first())->name(), -        
>                            KImageIO::Reading))))
> +            
> (KImageIO::isSupported(KMimeType::findByURL(lst.first())->name(),
> KImageIO::Reading)) || +             
> lst.first().fileName().endsWith(".svg") ||
> +              lst.first().fileName().endsWith(".svgz")))
>          {
>              bSetWallpaper = true;

I don't know much about our mimetype stuff, but isn't 

KMimeType::findByURL(lst.first())->is("image/svg+xml")

safer? Especially since it also contains the upper case file extensions?
[prev in list] [next in list] [prev in thread] [next in thread]