[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/kate/part
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2005-04-03 21:52:02
Message-ID: 20050403215202.262C35FA () office ! kde ! org
[Download RAW message or body]

CVS commit by dhaumann: 

Remove commented out code. Add some documentation.
Support for config pages works, the config pages itself are missing though :)


  M +2 -13     kateautoindent.cpp   1.58
  M +7 -7      kateautoindent.h   1.29


--- kdelibs/kate/part/kateautoindent.cpp  #1.57:1.58
@@ -2,4 +2,5 @@
    Copyright (C) 2003 Jesse Yurkovich <yurkjes@iit.edu>
    Copyright (C) 2004 >Anders Lund <anders@alweb.dk> (KateVarIndent class)
+   Copyright (C) 2005 Dominik Haumann <dhdev@gmx.de> (basic support for config page)
 
    This library is free software; you can redistribute it and/or
@@ -131,17 +132,5 @@ uint KateAutoIndent::modeNumber (const Q
 bool KateAutoIndent::hasConfigPage (uint mode)
 {
-  if (mode == KateDocumentConfig::imNormal)
-    return false;
-  else if (mode == KateDocumentConfig::imCStyle)
-    return false;
-  else if (mode == KateDocumentConfig::imPythonStyle)
-    return false;
-  else if (mode == KateDocumentConfig::imXmlStyle)
-    return false;
-  else if (mode == KateDocumentConfig::imCSAndS)
-    return false;
-  else if ( mode == KateDocumentConfig::imVarIndent )
-    return false;
-  else if ( mode == KateDocumentConfig::imScriptIndent )
+  if ( mode == KateDocumentConfig::imScriptIndent )
     return true;
 

--- kdelibs/kate/part/kateautoindent.h  #1.28:1.29
@@ -2,4 +2,5 @@
    Copyright (C) 2003 Jesse Yurkovich <yurkjes@iit.edu>
    Copyright (C) 2004 >Anders Lund <anders@alweb.dk> (KateVarIndent class)
+   Copyright (C) 2005 Dominik Haumann <dhdev@gmx.de> (basic support for config page)
 
    This library is free software; you can redistribute it and/or
@@ -52,13 +53,8 @@ class IndenterConfigPage : public QWidge
   public slots:
     /**
-     * Apply the changes.
+     * Apply the changes. Save options here, use @p kapp->config() and
+     * group [Kate Indenter MyIndenter].
      */
     virtual void apply () = 0;
-
-// dominik:
-// TODO: does it make sense to add this signal here and connect it to the OK-button
-//       from the config dialog?
-//   signals:
-//     void changed();
 };
 
@@ -185,4 +181,8 @@ class KateAutoIndent
 };
 
+/**
+ * This action provides a list of available indenters and gets plugged
+ * into the KateView's KActionCollection.
+ */
 class KateViewIndentationAction : public KActionMenu
 {


[prev in list] [next in list] [prev in thread] [next in thread]