[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdemultimedia/kscd
From:       André_Wöbbeking <Woebbeking () onlinehome ! de>
Date:       2005-04-03 21:40:40
Message-ID: 200504032340.40929.Woebbeking () onlinehome ! de
[Download RAW message or body]

On Sunday 03 April 2005 23:31, Shaheed Haque wrote:
> CVS commit by shaheed:
>
> 2. Improve documentation of return values, and overall usage of track
> numbers.

Thanks.

> +const QString &KCompactDisc::trackArtist(unsigned track) const
> +{
> +    if (NO_DISC || !TRACK_VALID(track))
> +        return "";
> +    return m_trackArtists[track - 1];
> +}

ouch! "" will create a temporary QString, nothing you can return as 
const reference. And you should avoid "", use QString() instead.
[prev in list] [next in list] [prev in thread] [next in thread]