[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdesupport/taglib/mpc
From:       Scott Wheeler <wheeler () kde ! org>
Date:       2005-04-03 16:47:02
Message-ID: 200504031847.02823.wheeler () kde ! org
[Download RAW message or body]

On Sunday 03 April 2005 18:41, Allan Sandfeld Jensen wrote:
> CVS commit by carewolf:
>
> Double-deleting won't make it much better
>
>
>   M +1 -1      mpcfile.cpp   1.12
>
>
> --- kdesupport/taglib/mpc/mpcfile.cpp  #1.11:1.12
> @@ -54,7 +54,7 @@ public:
>    ~FilePrivate()
>    {
> +    if (tag != ID3v1Tag && tag != APETag) delete tag;
>      delete ID3v1Tag;
>      delete APETag;
> -    delete tag;
>      delete ID3v2Header;
>      delete properties;

Hmm, that looks like a candidate for a nicer cleanup -- how about keeping 
"tag" just as a pointer to whatever is being used and keeping the pointers to 
the concrete ones separate?

-Scott

-- 
Anyone who has begun to think, places some portion of the world in jeopardy.
-John Dewey
[prev in list] [next in list] [prev in thread] [next in thread]