[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/khtml/ecma
From:       Mario Weilguni <mweilguni () sime ! com>
Date:       2005-03-31 6:31:09
Message-ID: 20050331063109.E18DD4A6 () office ! kde ! org
[Download RAW message or body]

CVS commit by mario: 

BUG:100079
Makes window.open be more tolerant to bad written pages. Accept the feature 
string with superfluous quotes at beginning and end.
patch by Allan Sandfield


  M +5 -0      kjs_window.cpp   1.399


--- kdelibs/khtml/ecma/kjs_window.cpp  #1.398:1.399
@@ -1318,4 +1318,9 @@ Value Window::openWindow(ExecState *exec
       features = args[2].toString(exec).qstring();
       // specifying window params means false defaults
+
+      // Buggy scripts have ' at beginning and end, cut those
+      if (features.startsWith("\'") && features.endsWith("\'"))
+        features = features.mid(1, features.length()-2);
+
       winargs.menuBarVisible = false;
       winargs.toolBarsVisible = false;


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic