[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdeplayground-pim/libical/src/libical
From:       Allen Winter <winterz () verizon ! net>
Date:       2005-03-30 18:21:29
Message-ID: 20050330182129.94F82632 () office ! kde ! org
[Download RAW message or body]

CVS commit by winterz: 

buffer overflow prevention using snprintf instead of sprintf.


  M +3 -3      icaltimezone.c   1.2


--- kdeplayground-pim/libical/src/libical/icaltimezone.c  #1.1:1.2
@@ -1645,7 +1645,7 @@ format_utc_offset			(int		 utc_offset,
 
   if (seconds == 0)
-    sprintf (buffer, "%s%02i%02i", sign, hours, minutes);
+    snprintf (buffer, sizeof(buffer), "%s%02i%02i", sign, hours, minutes);
   else
-    sprintf (buffer, "%s%02i%02i%02i", sign, hours, minutes, seconds);
+    snprintf (buffer, sizeof(buffer), "%s%02i%02i%02i", sign, hours, minutes, seconds);
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]