[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/khtml/rendering
From:       David Faure <faure () kde ! org>
Date:       2005-03-29 17:09:51
Message-ID: 20050329170951.7ACFE3CF () office ! kde ! org
[Download RAW message or body]

CVS commit by faure: 

Apply the fix for #97796 (radiobuttons emit onChange on loading) to checkboxes too.
Testcase from ysm: <input type="checkbox" checked=true onchange="alert('onchange')"/>
Will create testregression testcases now.
CCBUG: 97796


  M +4 -0      render_form.cpp   1.286


--- kdelibs/khtml/rendering/render_form.cpp  #1.285:1.286
@@ -122,4 +122,8 @@ RenderCheckBox::RenderCheckBox(HTMLInput
     b->setMouseTracking(true);
     setQWidget(b);
+
+    // prevent firing toggled() signals on initialization
+    b->setChecked(element->checked());
+
     connect(b,SIGNAL(stateChanged(int)),this,SLOT(slotStateChanged(int)));
 }


[prev in list] [next in list] [prev in thread] [next in thread]