[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kwin/clients/plastik
From:       Sandro Giessl <sandro () giessl ! com>
Date:       2005-03-26 22:52:18
Message-ID: 20050326225218.6422462B () office ! kde ! org
[Download RAW message or body]

CVS commit by giessl: 

revert the recent change which introduced button masking as it breaks Fitt's Law..


  M +2 -13     plastikbutton.cpp   1.18


--- kdebase/kwin/clients/plastik/plastikbutton.cpp  #1.17:1.18
@@ -113,12 +113,4 @@ void PlastikButton::reset(unsigned long 
         }
 
-        // button mask
-        if (type() != MenuButton) {
-            QRegion mask(rect() );
-            mask -= QRegion(0,0,1,1) + QRegion(0,height()-1,1,1) +
-                    QRegion(width()-1,0,1,1) + QRegion(width()-1,height()-1,1,1);
-            setMask(mask);
-        }
-
         this->update();
     }
@@ -209,9 +201,6 @@ void PlastikButton::drawButton(QPainter 
     QPainter bP(&buffer);
 
-    if (type() == MenuButton)
-    {
         // fake the titlebar background
         bP.drawTiledPixmap(0, 0, width(), width(), m_client->getTitleBarTile(active) );
-    }
 
     if (type() != MenuButton || hover || animProgress != 0) {


[prev in list] [next in list] [prev in thread] [next in thread]