[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdepim/akregator/src
From:       Nadeem Hasan <nhasan () nadmm ! com>
Date:       2005-03-20 14:14:53
Message-ID: 200503200914.57760.nhasan () nadmm ! com
[Download RAW message or body]


On Sunday 20 March 2005 06:04 am, Frank Osterfeld wrote:
> CVS commit by osterfeld:
>
> fix the order of the buttongroup members. The mapping of button<->enum
> value is based on the order in the XML file! Unbelievable and error-prone.

That is an incorrect statement. You can set the "buttonGroupId" in designer to 
force uic to use specific ids. By just rearranging the order you have pushed 
this problem to the future. The correct patch for the fix is below.


Index: settings_archive.ui
===================================================================
RCS file: /home/kde/kdepim/akregator/src/settings_archive.ui,v
retrieving revision 1.7
diff -u -3 -p -r1.7 settings_archive.ui
--- settings_archive.ui 21 Feb 2005 07:34:52 -0000      1.7
+++ settings_archive.ui 20 Mar 2005 14:12:25 -0000
@@ -41,6 +41,9 @@
                     <property name="text">
                         <string>Keep all articles</string>
                     </property>
+                    <property name="buttonGroupId">
+                        <number>0</number>
+                    </property>
                 </widget>
                 <widget class="QRadioButton" row="3" column="0" rowspan="1" 
colspan="2">
                     <property name="name">
@@ -49,6 +52,9 @@
                     <property name="text">
                         <string>Disable archiving</string>
                     </property>
+                    <property name="buttonGroupId">
+                        <number>3</number>
+                    </property>
                 </widget>
                 <widget class="QRadioButton" row="1" column="0">
                     <property name="name">
@@ -57,6 +63,9 @@
                     <property name="text">
                         <string>Limit feed archive size to:</string>
                     </property>
+                    <property name="buttonGroupId">
+                        <number>1</number>
+                    </property>
                 </widget>
                 <widget class="KIntSpinBox" row="1" column="1">
                     <property name="name">
@@ -91,6 +100,9 @@
                     <property name="text">
                         <string>Delete articles older than: </string>
                     </property>
+                    <property name="buttonGroupId">
+                        <number>2</number>
+                    </property>
                 </widget>
                 <widget class="KIntSpinBox" row="2" column="1">
                     <property name="name">

-- 
Nadeem Hasan
GPG Fingerprint: 7141 0B1C 9CAF 624D 307F F8EF 6C0C 753E DD3A 0F53

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]