From kde-commits  Thu Mar 17 16:18:18 2005
From: Tobias Anton <tobias.anton () esc-electronics ! de>
Date: Thu, 17 Mar 2005 16:18:18 +0000
To: kde-commits
Subject: Re: kdelibs/khtml/html
Message-Id: <200503171718.18957.tobias.anton () esc-electronics ! de>
X-MARC-Message: https://marc.info/?l=kde-commits&m=111107631322374

Why didn't you simply override

HTMLInputElementImpl::isFocusable()

?


Cheers
-- Tobias


Am Dienstag, 15. März 2005 07:36 schrieb Mario Weilguni:
> CVS commit by mario:
>
> BUG:53038
> FORM elements <INPUT type="Image"> accept tab focus now.
>
>
>   M +7 -2      html_formimpl.cpp   1.428
>
>
> --- kdelibs/khtml/html/html_formimpl.cpp  #1.427:1.428
> @@ -899,7 +899,12 @@ void HTMLGenericFormElementImpl::setDisa
>  bool HTMLGenericFormElementImpl::isFocusable() const
>  {
> -    return  m_render && m_render->isWidget() &&
> +    return (m_render && m_render->isWidget() &&
>          static_cast<RenderWidget*>(m_render)->widget() &&
> -        static_cast<RenderWidget*>(m_render)->widget()->focusPolicy() >=
> QWidget::TabFocus; +       
> static_cast<RenderWidget*>(m_render)->widget()->focusPolicy() >=
> QWidget::TabFocus) || +                /* INPUT TYPE="image" supports focus
> too */
> +                (
> +                        id() == ID_INPUT &&
> +                        static_cast<const HTMLInputElementImpl
> *>(this)->inputType() == HTMLInputElementImpl::IMAGE +                );
>  }