[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kioslave/http
From:       "Dawit A." <adawit () kde ! org>
Date:       2005-03-10 23:28:57
Message-ID: 200503101828.57747.adawit () kde ! org
[Download RAW message or body]


You should only disable it when the proxy is in use whether or not there is an 
option for in the proxy dialog...

On Thursday 10 March 2005 07:42, Thiago Macieira wrote:
> CVS commit by thiago:
>
> Committing a fix for bug 101149: kio_http does its own proxying, so no
> need to use KSocks for anything. This, however, means that kio_http no
> longer abides by the global SOCKS proxy rule -- then again, there's a
> specific KCM for configuring kio_http's proxies, with no option "use
> global SOCKS proxies". That's something to be fixed in the future.
>
> To be backported.
> BUG:101149
>
>
>   M +2 -0      http.cc   1.641
>
>
> --- kdelibs/kioslave/http/http.cc  #1.640:1.641
> @@ -1958,4 +1958,6 @@ bool HTTPProtocol::httpOpenConnection()
>
>    setBlockConnection( true );
> +  // kio_http uses its own proxying:
> +  KSocks::self()->disableSocks();
>
>    if ( m_state.doProxy )

-- 
Regards,
Dawit A.
"Practice what you preach, preach what you practice"
[prev in list] [next in list] [prev in thread] [next in thread]