[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kate/part
From:       Mickael Marchand <marchand () kde ! org>
Date:       2005-03-10 20:12:02
Message-ID: 4230AA12.7050408 () kde ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christoph Cullmann a écrit :
| CVS commit by cullmann:
|
| fix memleak
| nice that yzis uses our hl, even found bug in it and NOT submited any
notice or patch
| yeah, I like cooperation ;)

I am really sorry.
I was tracking the awful kdevelop crash that we had (and actually still
have) with kyzis and trying to understand what valgrind was telling me,
then I just forgot about this patch.
you might also want to run valgrind too, iirc there were some more
suspicious warnings I had no time to look at seriously.

please accept my apoligizes.

Mik


|
|   M +10 -0     katehighlight.cpp   1.217
|
|
| --- kdelibs/kate/part/katehighlight.cpp  #1.216:1.217
| @@ -1213,6 +1213,8 @@ KateHighlighting::KateHighlighting(const
|  KateHighlighting::~KateHighlighting()
|  {
| +  // cu contexts
|    for (uint i=0; i < m_contexts.size(); ++i)
|      delete m_contexts[i];
| +  m_contexts.clear ();
|  }
|
| @@ -1760,5 +1762,9 @@ void KateHighlighting::init()
|      return;
|
| +  // cu contexts
| +  for (uint i=0; i < m_contexts.size(); ++i)
| +    delete m_contexts[i];
|    m_contexts.clear ();
| +
|    makeContextList();
|  }
| @@ -1774,5 +1780,9 @@ void KateHighlighting::done()
|      return;
|
| +  // cu contexts
| +  for (uint i=0; i < m_contexts.size(); ++i)
| +    delete m_contexts[i];
|    m_contexts.clear ();
| +
|    internalIDList.clear();
|  }
|
|

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCMKoFyOYzc4nQ8j0RAisyAJ9Ujc2HewrO229z6AcViG60Q2CcpgCgn67x
s6mj6FqpKXoNvbLZL9OYvEU=
=cCre
-----END PGP SIGNATURE-----
[prev in list] [next in list] [prev in thread] [next in thread]