[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdevelop/languages/cpp
From:       Adam Treat <manyoso () yahoo ! com>
Date:       2005-03-09 15:17:54
Message-ID: 200503091017.55054.manyoso () yahoo ! com
[Download RAW message or body]

The code in question was in serious need of reformatting.  The 
cppsupportpart.cpp file alone had FOUR different copyright authors, but 
seemingly TWELVE different coding styles.  Besides, this was discussed with 
the current KDevelop maintainer.

On Wednesday 09 March 2005 5:56 am, Richard Dale wrote:
> Isn't it normal to discuss with the author, before you go about reformating
> all their code?
>
> -- Richard
>
> On Tuesday 08 March 2005 22:41, Matt Rogers wrote:
> > CVS commit by mattr:
> >
> > ran through astyle and added modelines.
> >
> > Happy recompile. :)
> >
> >
> >   M +11 -10    KDevCppSupportIface.h   1.2
> >   M +38 -36    addattributedialog.h   1.4
> >   M +40 -38    addmethoddialog.h   1.5
> >   M +17 -12    ast_utils.h   1.9
> >   M +73 -50    backgroundparser.h   1.28
> >   M +29 -27    ccconfigwidget.h   1.15
> >   M +50 -48    classgeneratorconfig.h   1.3
> >   M +31 -29    codeinformationrepository.h   1.13
> >   M +49 -47    configproblemreporter.ui.h   1.9
> >   M +381 -307  cpp_tags.h   1.4
> >   M +9 -8      cppcodecompletion.h   1.50
> >   M +71 -70    cppcodecompletionconfig.h   1.4
> >   M +24 -22    cppimplementationwidget.h   1.2
> >   M +242 -223  cppnewclassdlg.h   1.20
> >   M +37 -28    cppsupport_events.h   1.12
> >   M +12 -10    cppsupport_utils.h   1.4
> >   M +16 -14    cppsupportfactory.h   1.6
> >   M +209 -183  cppsupportpart.h   1.89
> >   M +29 -27    createpcsdialog.h   1.2
> >   M +17 -13    doxydoc.h   1.2
> >   M +5 -3      kdevdeepcopy.h   1.2
> >   M +18 -16    kdevdriver.h   1.8
> >   M +70 -66    problemreporter.h   1.16
> >   M +27 -25    qtdesignercppintegration.h   1.2
> >   M +68 -63    store_walker.h   1.17
> >   M +19 -16    storeconverter.h   1.3
> >   M +55 -54    subclassingdlg.h   1.5
> >   M +65 -63    tag_creator.h   1.13
[prev in list] [next in list] [prev in thread] [next in thread]