[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kicker
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2005-02-27 4:16:40
Message-ID: 20050227041640.DD761148A2 () office ! kde ! org
[Download RAW message or body]

CVS commit by aseigo: 

properly position first items when using "insert into first free space"
method. makes the menubar appear properly. swank.


  M +0 -2      TODO   1.45
  M +11 -1     core/containerarealayout.cpp   1.10


--- kdebase/kicker/TODO  #1.44:1.45
@@ -8,6 +8,4 @@
 Patches welcome! - Aaron
 
-Menu applet handling
-    - get resizing working properly
 Autoexpending panels on the same side of the screen need to stop expanding
     at the point they run into each other.

--- kdebase/kicker/core/containerarealayout.cpp  #1.9:1.10
@@ -208,4 +208,6 @@ void ContainerAreaLayout::insertIntoFree
     if (!item)
     {
+        // this should never happen as we just added the item above
+        // but we do this to be safe.
         return;
     }
@@ -214,5 +216,5 @@ void ContainerAreaLayout::insertIntoFree
     if (!current.current())
     {
-        moveContainerSwitch(item->item->widget(), 0);
+        // this shouldn't happen either, but again... we try and be safe
         return;
     }
@@ -221,4 +223,12 @@ void ContainerAreaLayout::insertIntoFree
     ++next;
 
+    if (!next.current())
+    {
+        // first item in!
+        item->setGeometryR(QRect(0, 0, widget->width(), widget->height()));
+        updateFreeSpaceValues();
+        return;
+    }
+
     for (; next.current(); ++current, ++next)
     {


[prev in list] [next in list] [prev in thread] [next in thread]