[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/konqueror/listview
From:       David Faure <faure () kde ! org>
Date:       2005-02-25 18:03:52
Message-ID: 20050225180352.44D93EF06 () office ! kde ! org
[Download RAW message or body]

CVS commit by faure: 

Let's be nice and honour the selected-text color from "kcmshell colors",
otherwise the text might not be readable at all depending on the "selection \
background" color.

I'm leaving the (arguable) hardcoded text colors for the normal items,
but at least the selected item is always readable now.

BUG: reported on IRC yesterday by motoom


  M +2 -1      konq_textviewitem.cc   1.34
  M +0 -11     konq_textviewwidget.cc   1.48
  M +0 -1      konq_textviewwidget.h   1.17


--- kdebase/konqueror/listview/konq_textviewitem.cc  #1.33:1.34
@@ -201,5 +201,6 @@ void KonqTextViewItem::paintCell( QPaint
    QColorGroup cg( _cg );
    cg.setColor(QColorGroup::Text, static_cast<KonqTextViewWidget \
                *>(listView())->colors[type]);
-   cg.setColor(QColorGroup::HighlightedText, static_cast<KonqTextViewWidget \
*>(listView())->highlight[type]); +   // Don't do that! Keep things readable whatever \
the selection background color is +//   cg.setColor(QColorGroup::HighlightedText, \
static_cast<KonqTextViewWidget *>(listView())->highlight[type]);  //   \
cg.setColor(QColorGroup::Highlight, Qt::darkGray);  

--- kdebase/konqueror/listview/konq_textviewwidget.cc  #1.47:1.48
@@ -56,15 +56,4 @@ KonqTextViewWidget::KonqTextViewWidget( 
    colors[KTVI_BLOCKDEV]=Qt::blue;
 
-   highlight[KTVI_REGULAR]=Qt::white;
-   highlight[KTVI_EXEC]=colors[KTVI_EXEC].light(200);
-   highlight[KTVI_REGULARLINK]=Qt::white;
-   highlight[KTVI_DIR]=Qt::white;
-   highlight[KTVI_DIRLINK]=Qt::white;
-   highlight[KTVI_BADLINK]=colors[KTVI_BADLINK].light();
-   highlight[KTVI_SOCKET]=colors[KTVI_SOCKET].light();
-   highlight[KTVI_FIFO]=colors[KTVI_FIFO].light();
-   highlight[KTVI_UNKNOWN]=colors[KTVI_UNKNOWN].light();
-   highlight[KTVI_CHARDEV]=colors[KTVI_CHARDEV].light(180);
-   highlight[KTVI_BLOCKDEV]=colors[KTVI_BLOCKDEV].light(180);
    m_showIcons=FALSE;
 }

--- kdebase/konqueror/listview/konq_textviewwidget.h  #1.16:1.17
@@ -50,5 +50,4 @@ class KonqTextViewWidget : public KonqBa
 
       QColor colors[11];
-      QColor highlight[11];
 };
 


[prev in list] [next in list] [prev in thread] [next in thread]