[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/khelpcenter
From:       David Faure <faure () kde ! org>
Date:       2005-02-25 17:32:04
Message-ID: 200502251832.04396.faure () kde ! org
[Download RAW message or body]

On Friday 25 February 2005 18:29, Waldo Bastian wrote:
> CVS commit by waba: 
> 
> Fix initial size
> 
> 
>   M +2 -1      mainwindow.cpp   1.67
> 
> 
> --- kdebase/khelpcenter/mainwindow.cpp  #1.66:1.67
> @@ -146,5 +146,6 @@ MainWindow::MainWindow()
>      actionCollection()->addDocCollection( mDoc->actionCollection() );
>  
> -    setupGUI();
> +    setupGUI(ToolBar | Keys | StatusBar | Create);
> +    setAutoSaveSettings();

This looks a bit wrong to me - the whole point of setupGUI was to do all this. 

If the problem is this code in KMainWindow, why not remove it?
 
        // setupGUI() is typically called in the constructor before show(),
        // so the default window size will be incorrect unless the application
        // hard coded the size which they should try not to do (i.e. use
        // size hints).
        if(!isShown())
          adjustSize();

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]