[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kicker/taskmanager
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2005-02-24 11:15:12
Message-ID: 200502241215.12531.l.lunak () suse ! cz
[Download RAW message or body]

Dne čt 24. února 2005 04:30 Aaron J. Seigo napsal(a):
> CVS commit by aseigo:
>
> make sure the window still is around before accessing its attributes
> i wonder if this is the cause of the "crashes when i close the gimp" bugs?
> CCBUG:97083
>
>
>   M +45 -35    taskmanager.cpp   1.89
>
>
> --- kdebase/kicker/taskmanager/taskmanager.cpp  #1.88:1.89
> @@ -476,35 +476,35 @@ void Task::setActive(bool a)
>  bool Task::isMaximized() const
>  {
> -    return(_info.state() & NET::Max);
> +    return _info.valid() && (_info.state() & NET::Max);
>  }

 Hmm, are you sure this actually does something? KWin::WindowInfo fetches all 
the data and sets the valid flag in the ctor. Statements like the one above 
only access the already read data.

-- 
 Lubos Lunak
 KDE Developer

[prev in list] [next in list] [prev in thread] [next in thread]