[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdemultimedia/juk
From:       Scott Wheeler <wheeler () kde ! org>
Date:       2005-02-23 4:38:09
Message-ID: 20050223043809.9372CEA9D () office ! kde ! org
[Download RAW message or body]

CVS commit by wheeler: 

Ok, more than five hours late and coolo still hasn't turned me into a pumpkin.
I've been assured that this will happen in the morning, though after three hours
of sleep, I think the effect would be natural.

The moral of the story:  test features in apps you maintain before the day of the
freeze.  (I knew that the play queue was broken, but not quite how badly -- this
was mostly Michael's turf, but he's away for another few weeks.)

Ok, so stuff that happened:

Fixed the "magical not-showing-back-up" Play Queue (was related to saving the
play queue, which even when set up properly just caused all sorts of crashes.
Commented out for now, ideally to be reenabled in 3.4.1) -- #99191

Fixed up a lot of the quirkiness with the interaction of the Play Queue and the
rest of the application playlists.  This hopefully fixes #98473 (if not, just
reopen)

Double clicking on an item (anywhere) plays it immediately. #97021

And the catch all, #88888, "this sucks" was mostly implemented.  Some of the things
I took a different line on, but you got at least 3 of the 6.  The last two I don't
agree with.  If you feel so compelled, open more specific requests from here on out.

Basically this structurally changed things so that instead of adding items to the
play queue when turned on and always using that as the main location for playing
now the play queue is only used when there's stuff in it.  When it's empty again
playing resumes in the list that the last item in the play queue came from.  It
will jump back into the play queue as soon as something is added.

This is still a little rough, but it doesn't crash all the time like it was before
(fixed at least three crashes on this one) and is close enough to actually being
releasable for me to now get a couple hours sleep.

BUG:99191
BUG:98473
BUG:97021
BUG:88888


  M +4 -2      cache.cpp   1.33
  M +1 -1      collectionlist.h   1.64
  M +1 -1      jukui-rtl.rc   1.8
  M +1 -1      jukui.rc   1.59
  M +9 -7      playlist.cpp   1.300
  M +4 -11     playlist.h   1.157
  M +1 -3      playlistcollection.cpp   1.69
  M +0 -7      playlistcollection.h   1.38
  M +1 -0      playlistitem.h   1.68
  M +4 -2      tracksequencemanager.cpp   1.5
  M +52 -113   upcomingplaylist.cpp   1.9
  M +8 -16     upcomingplaylist.h   1.8



[prev in list] [next in list] [prev in thread] [next in thread]