[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kicker/core
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2005-02-21 7:17:24
Message-ID: 20050221071724.59C771CBAF () office ! kde ! org
[Download RAW message or body]

CVS commit by aseigo: 

document the reason why menumanager can't be static deleted
(aw feck. cvs: do as i think, not as i say!)


  M +9 -0      menumanager.cpp   1.7


--- kdebase/kicker/core/menumanager.cpp  #1.6:1.7
@@ -38,4 +38,13 @@ CONNECTION WITH THE SOFTWARE OR THE USE 
 #include "menumanager.moc"
 
+// Why MenuManager doesn't use KStaticDeleter
+// MenuManager gets created before the ExtensionManager
+// So using KStaticDeleter results in MenuManager getting
+// deleted before ExtensionManager, which means also the panels
+// which means also the K Menu buttons. K Menu buttons call
+// MenuManager in their dtor, so if MenuManager is already gone
+// then every KButton will cause it to be reconstructed.
+// So we rely on Kicker to delete MenuManager on the way out
+// ensuring it's the last thing to go.
 MenuManager* MenuManager::m_self = 0;
 


[prev in list] [next in list] [prev in thread] [next in thread]