[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/konqueror
From:       David Faure <faure () kde ! org>
Date:       2005-02-18 15:47:45
Message-ID: 20050218154745.C0BC31D6B6 () office ! kde ! org
[Download RAW message or body]

CVS commit by faure: 

GUI: Remove "Tools / Run Command". As a discussion on kde-usability pointed out \
(allegedly), this is redundant with "Execute Shell Command", which is better suited \
for a file manager (it works on the current directory). "Run Command" opened minicli, \
which is already available in kicker - and which isn't available when using konqueror
in a non-KDE environment (due to kdesktop not running).


  M +1 -2      konq-simplebrowser.rc   1.6
  M +0 -9      konq_mainwindow.cc   1.1404
  M +0 -1      konq_mainwindow.h   1.458
  M +1 -2      konqueror.rc   1.127


--- kdebase/konqueror/konq-simplebrowser.rc  #1.5:1.6
@@ -1,5 +1,5 @@
 <?xml version = '1.0'?>
 <!DOCTYPE gui SYSTEM "kpartgui.dtd">
-<gui version="51" name="Konqueror" >
+<gui version="52" name="Konqueror" >
  <MenuBar>
   <Menu noMerge="1" name="file" >
@@ -40,5 +40,4 @@
   <Menu name="tools" >
    <text>&amp;Tools</text>
-   <Action name="run" />
    <Merge/>
   </Menu>

--- kdebase/konqueror/konq_mainwindow.cc  #1.1403:1.1404
@@ -1362,12 +1362,4 @@ void KonqMainWindow::slotSendFile()
 }
 
-void KonqMainWindow::slotRun()
-{
-  // HACK: The command is not executed in the directory
-  // we are in currently. Minicli does not support that yet
-  QByteArray data;
-  kapp->dcopClient()->send( "kdesktop", "KDesktopIface", "popupExecuteCommand()", \
                data );
-}
-
 void KonqMainWindow::slotOpenTerminal()
 {
@@ -3677,5 +3669,4 @@ void KonqMainWindow::initActions()
   (void) new KAction( i18n( "Send &Link Address..." ), "mail_generic", 0, this, \
SLOT( slotSendURL() ), actionCollection(), "sendURL" );  (void) new KAction( i18n( \
"S&end File..." ), "mail_generic", 0, this, SLOT( slotSendFile() ), \
                actionCollection(), "sendPage" );
-  (void) new KAction( i18n( "&Run Command..." ), "run", 0/*kdesktop has a binding \
for it*/, this, SLOT( slotRun() ), actionCollection(), "run" );  if \
(kapp->authorize("shell_access"))  {

--- kdebase/konqueror/konq_mainwindow.h  #1.457:1.458
@@ -358,5 +358,4 @@ public slots:
   void slotSendURL();
   void slotSendFile();
-  void slotRun();
   void slotCopyFiles();
   void slotMoveFiles();

--- kdebase/konqueror/konqueror.rc  #1.126:1.127
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
 <!DOCTYPE gui SYSTEM "kpartgui.dtd">
-<gui name="Konqueror" version="56">
+<gui name="Konqueror" version="57">
 <MenuBar>
  <Menu name="file" noMerge="1"><text>&amp;Location</text>
@@ -66,5 +66,4 @@
  <Action name="bookmarks"/>
  <Menu name="tools"><text>&amp;Tools</text>
-  <Action name="run"/>
   <Action name="open_terminal"/>
   <Action name="findfile"/>


[prev in list] [next in list] [prev in thread] [next in thread]