[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdegraphics/kpdf/core
From:       Albert Astals Cid <astals11 () terra ! es>
Date:       2005-02-11 23:14:00
Message-ID: 200502120014.00921.astals11 () terra ! es
[Download RAW message or body]

Hi Dirk, thanks for the fix, but in the future could you be a bit more 
specific like "fix compile with gcc-foo" or "fix compile with that options" 
or something along the lines. I mean it was compiling here.

Albert

A Divendres 11 Febrer 2005 23:29, Dirk Mueller va escriure:
> CVS commit by mueller:
>
> fix compile
>
>
>   M +4 -4      page.cpp   1.20
>
>
> --- kdegraphics/kpdf/core/page.cpp  #1.19:1.20
> @@ -111,5 +111,5 @@ NormalizedRect * KPDFPage::findText( con
>      const QChar * str = text.unicode();
>      int len = text.length();
> -    Unicode u[ len ];
> +    QMemArray<Unicode> u(len);
>      for (int i = 0; i < len; ++i)
>          u[i] = str[i].unicode();
> @@ -131,10 +131,10 @@ NormalizedRect * KPDFPage::findText( con
>      {
>          if ( dir == FromTop )
> -            found = m_text->findText( u, len, gTrue, gTrue, gFalse,
> gFalse, &sLeft, &sTop, &sRight, &sBottom ); +            found =
> m_text->findText( const_cast<Unicode*>(static_cast<const Unicode*>(u)),
> len, gTrue, gTrue, gFalse, gFalse, &sLeft, &sTop, &sRight, &sBottom ); else
> if ( dir == NextMatch )
> -            found = m_text->findText( u, len, gFalse, gTrue, gTrue,
> gFalse, &sLeft, &sTop, &sRight, &sBottom ); +            found =
> m_text->findText( const_cast<Unicode*>(static_cast<const Unicode*>(u)),
> len, gFalse, gTrue, gTrue, gFalse, &sLeft, &sTop, &sRight, &sBottom ); else
> if ( dir == PrevMatch )
>              // FIXME: this doesn't work as expected (luckily backward
> search isn't yet used) -            found = m_text->findText( u, len,
> gTrue, gFalse, gFalse, gTrue, &sLeft, &sTop, &sRight, &sBottom ); +        
>    found = m_text->findText( const_cast<Unicode*>(static_cast<const
> Unicode*>(u)), len, gTrue, gFalse, gFalse, gTrue, &sLeft, &sTop, &sRight,
> &sBottom );
>
>          // if not found (even in case unsensitive search), terminate
[prev in list] [next in list] [prev in thread] [next in thread]