[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio/bookmarks
From:       David Faure <faure () kde ! org>
Date:       2005-02-10 13:52:39
Message-ID: 200502101452.40364.faure () kde ! org
[Download RAW message or body]

On Thursday 10 February 2005 07:15, Frerich Raabe wrote:
> This is IMHO just a minor nuisance. For what it's worth, a bookmark which has 
> something like '<info><metadata/></info>' is not considered to have metadata 
> (hence this function didn't create any meta data) - having the element alone 
> is not sufficient, it has to have child elements as well.

My bookmarks.xml has 1416 lines, for 289 bookmarks. Only 52 bookmarks have metadata, the rest doesn't.
Your code (if applied to all bookmarks - although I guess that's not the case currently?) would
create '<info>\n<metadata/>\n</info>\n' for every bookmark that doesn't have it yet, thus adding
3 lines to 237 bookmarks, i.e. 711 lines - an increase of 50% in number of lines (the ratio
is smaller in bytes of course).

Well, I suppose all bookmarks will eventually get metadata if using them for browsing,
but that will take quite some time :)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]