[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: kdebase/kdesktop
From: David Faure <faure () kde ! org>
Date: 2005-02-07 17:29:12
Message-ID: 200502071829.13337.faure () kde ! org
[Download RAW message or body]
On Monday 07 February 2005 12:45, you wrote:
> On Monday 07 February 2005 12:22, you wrote:
> > > Solution: don't delete settings in IconPositions file when the icons are
> > > not yet existing
> >
> > Good catch.
> >
> > Problem is: nothing deletes entries from the icon positions config file
> > anymore, AFAICS. Maybe this should be done at least from slotDeleteItem(),
> > when a file is deleted or disappears ?
>
> Infact, I thought this, too and had a bool argument in saveIconPositions,
> which was only called with true (cleanup) in the destructor.
>
> But I've seen, that this was not needed, as also removed items are already
> deleted again.
>
> In slotDeleteItem there is already
> m_dotDirectory->deleteGroup( group );
Oh, my bad. I only grepped for deleteEntry, forgetting that this config file uses
one group per file.
Thanks a lot for your work, much appreciated.
--
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic