[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/klipper
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2005-02-07 13:07:52
Message-ID: 200502071407.52423.l.lunak () suse ! cz
[Download RAW message or body]

On Friday 04 of February 2005 21:25, Esben Mose Hansen wrote:
> CVS commit by esben:
>
> This is a workaround for a (x)emacs bug.  The problem is that XEmacs
> freezes if asked to copy >=262041 bytes. Thats just under 256, so I
> suspect a char[256*1024] inside XEmacs.

 I don't see anything in the patch that would be related to this.

> To make matters worse, XEmacs 
> always respond none to the XConvertSelection with
> Atom("TIMESTAMP"). Which causes Klipper to poll XEmacs every 1000ms,
> each time causing QT to wait for 5s before timing out. In other words,
> Klipper is out for the count until the user presses ctrl-G This fix
> request the TARGETS property instead, which seem better supported.

 Please revert. You cannot simply use another property just because it seems 
to work, just like you cannot use a different variable when something is 
wrong with the one you should use.

 The TIMESTAMP target means the timestamp of when the selection has been 
acquired by the owner (http://tronche.com/gui/x/icccm/sec-2.html#s-2.6.2), 
and Klipper checks it to see whether the clipboard contents have changed. 
When XEmacs responds None to this target it means it doesn't support it, in 
which case Klipper simply has to poll the contents (like it's been doing 
since ever). There should be no problem with this[*].

 If there's something causing QClipboard timeouts, it's most probably 
something else. Do you have a specific bugreport for this problem?

[*] Well, actually Klipper should finally start using the XFixes extension for 
this when available. I wonder if a patch for this could count as a bugfix ;).

>
>   M +5 -5      clipboardpoll.cpp   1.12
>   M +2 -2      clipboardpoll.h   1.7

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@suse.cz , l.lunak@kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
[prev in list] [next in list] [prev in thread] [next in thread]