[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdeextragear-1/amarok/src
From:       Max Howell <max.howell () methylblue ! com>
Date:       2005-02-07 12:52:32
Message-ID: 20050207125232.E5F341D051 () office ! kde ! org
[Download RAW message or body]

CVS commit by mhowell: 

We have had 3 bts that show a crash in MetaBundle::prettyBitrate() this may fix that \
crash.


  M +3 -3      metabundle.cpp   1.45
  M +3 -3      metabundle.h   1.50


--- kdeextragear-1/amarok/src/metabundle.cpp  #1.44:1.45
@@ -234,5 +234,5 @@ MetaBundle::prettyLength( int seconds ) 
 
 QString
-MetaBundle::prettyTime( int seconds, bool showHours ) //static
+MetaBundle::prettyTime( uint seconds, bool showHours ) //static
 {
     QString s = QChar( ':' );
@@ -254,7 +254,7 @@ MetaBundle::prettyTime( int seconds, boo
 
 QString
-MetaBundle::prettyBitrate( int i )
+MetaBundle::prettyBitrate( uint i )
 {
-    return ( i % 32 == 0 && i < 257 ) ? bitrateStore[ i /32 ] : prettyGeneric( i18n( \
"Bitrate", "%1 kbps" ), i ); +    return ( i % 32 == 0 && i < 257 ) ? bitrateStore[ i \
/ 32 ] : prettyGeneric( i18n( "Bitrate", "%1 kbps" ), i );  }
 

--- kdeextragear-1/amarok/src/metabundle.h  #1.49:1.50
@@ -104,7 +104,7 @@ public:
     // these are helpful statics, don't use these in preference
     // to the ones above!
-    static QString prettyBitrate( int );
-    static QString prettyLength( int );
-    static QString prettyTime( int, bool showHours = true );
+    static QString prettyBitrate( uint );
+    static QString prettyLength( int ); //must be int, see Unavailable, etc. above
+    static QString prettyTime( uint, bool showHours = true );
     static QString zeroPad( uint i ) { return ( i < 10 ) ? QString( "0%1" ).arg( i ) \
: QString::number( i ); }  static QString prettyTitle( QString );


[prev in list] [next in list] [prev in thread] [next in thread]