[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio/kfile
From:       David Faure <faure () kde ! org>
Date:       2005-02-07 12:44:16
Message-ID: 200502071344.16728.faure () kde ! org
[Download RAW message or body]

On Tuesday 18 January 2005 23:11, Stephan Binner wrote:
> CVS commit by binner: 
> 
> Respect "ShowDeleteCommand" option (#96370)
> Make Shift+"Move to Trash" delete
> 
> 
>   M +14 -4     kdiroperator.cpp   1.198
>   M +1 -1      kdiroperator.h   1.98
> 
> 
> @@ -1368,4 +1374,8 @@ void KDirOperator::setupMenu(int whichAc
>          actionMenu->insert( mkdirAction );
>          actionMenu->insert( myActionCollection->action( "trash" ) );
> +        
> +        KConfig globalconfig("kdeglobals", true, false);
> +        globalconfig.setGroup( "KDE" );
> +        if ( globalconfig.readBoolEntry("ShowDeleteCommand", false) )
>          actionMenu->insert( myActionCollection->action( "delete" ) );

Shouldn't this be
 if ( localfile )
     insert action("trash")
 if ( !localfile || showDeleteCommand ) 
    insert action("delete")
like in konq_popupmenu?

Otherwise we show only "trash" and no "delete" on remote protocols (and pseudo-remote ones,
like system:/).

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]