[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kicker/applets/clock
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2005-02-05 22:15:48
Message-ID: 200502051515.57753.aseigo () kde ! org
[Download RAW message or body]


On Saturday 05 February 2005 08:42, George Staikos wrote:
> On Saturday 05 February 2005 02:38, Aaron J. Seigo wrote:
> > CVS commit by aseigo:
> >
> > do this slightly differently. don't replace any characters, but force a
> > wrap. if this wraps when it shouldn't then pick a better font size or fix
> > your font subsystem so it reports proper font metrics.
> > BUG:98380
>
>   This can't internationalize well, right?  How do we know what (year,
> month, or day) gets wrapped to the next row?

whatever the first non-numeric character from the right side is is where the 
break happens. it's word wrapping, plain and simple. the user can pick a 
smaller font or a bigger panel size if this bugs them; it's 100% a result of 
user configuration choices.

now, whether or not this i18n's well, it fixes a very real bug that was 
reported many times over and was pretty obvious and very amateurish looking 
(the date label being shoved way off to the right and cut off). i've tried 
many different ways of fixing it, but QLabel's word wrapping is just not 
designed to be used in these sorts of situations. 

honestly, the clock applet needs to be kicked to the curb and rewritten, 
probably not using label widgets but painting the text itself directly. this 
would be faster, result in lower memory consumption and make solving these 
sorts of issues simpler. not to mention allow us to make it prettier.

but this is as good as it gets for 3.4.

-- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]