[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdegraphics/kolourpaint
From:       Clarence Dang <dang () kde ! org>
Date:       2005-02-02 11:16:51
Message-ID: 20050202111651.2647C1D158 () office ! kde ! org
[Download RAW message or body]

CVS commit by dang: 

Change "Set As Image" a.k.a "Crop" behaviour for the 2nd time.

Old: Selection pulled off, moved to (0,0), document set to background
     colour outside of selection and where selection opaque
Problems: Like with "Edit / Copy to File...", it was found that pulling
          off selection was unexpected (if sel set to trans and esp.
          with Colour Similarity on).  Furthermore, setting doc pixels
          to background colour is artificial without much justification
          - it attempts to simulate sel pull-off but why not just paste
          down the sel in the first place ("Set as Image", after all)
          to allow pull-off.  And it doesn't work well with antialising
          opaque foreground text with transparent background.
New: If text box, same behaviour as old (move to (0,0)), except doc
     background always becomes completely transparent (avoids false
     antialising with transparent text box background and for opaque
     text box background, makes extend of text box clearer if moving
     text box).  So as with old, not really "Set as Image" but we want
     to keep text box editable - you can just deselect it afterwards
     anyway.

     If ordinary selection, firstly, no pull-off.  Second, it _really_
     pastes down / sets the selection as the doc (bits of doc outside sel
     _region_ are set to background colour).  So the selection is gone
     (even if it was floating before).  For convenience, it adds a create
     sel border cmd immediately afterwards.  You can then pull off the
     sel if you must.

Hopefully new behaviour is more intuitive.  Thanks to Michael Lake for the
feedback regarding the unexpected pull-off.

Add kpToolClearCommand constructor overload to specify a particular back colour.


  M +2 -1      kpmainwindow_image.cpp   1.35
  M +10 -0     tools/kptoolclear.cpp   1.12
  M +6 -2      tools/kptoolclear.h   1.8
  M +213 -62   tools/kptoolcrop.cpp   1.7
  M +1 -8      tools/kptoolcrop.h   1.4
  M +4 -0      tools/kptoolselection.cpp   1.42



[prev in list] [next in list] [prev in thread] [next in thread]