[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kutils
From:       Benjamin Meyer <ben () meyerhome ! net>
Date:       2005-02-01 4:52:47
Message-ID: 200502010452.48006.ben () meyerhome ! net
[Download RAW message or body]

On Tuesday 01 February 2005 4:53 am, Frans Englich wrote:
> On Tuesday 01 February 2005 04:42, Benjamin Meyer wrote:
> > On Tuesday 01 February 2005 4:30 am, Frans Englich wrote:
> > > CVS commit by englich:
> > >
> > >
> > > Completely remove the QScrollView(d->view). Since Aaron disabled it and
> > > hence the reason why it was put there in the first place, it's better
> > > to remove it completely than to try to disable it with hacks. But dunno
> > > what this might have broken -- please test.
> > >
> > > Benjamin, did this change break any case of yours?
> > > CCMAIL:  Benjamin Meyer <ben@meyerhome.net>
> > > CCMAIL: 83506
> > >
> > >
> > >   M +2 -0      TODO   1.3
> > >   M +16 -33    kcmoduleproxy.cpp   1.12
> >
> > Yup, the sizeHint() no longer works :)
>
> Suspected, what is the user visible/concrete effect of that?

It was returning twice the real hint height/width.

Actually the hack is no longer needed at all and removing the scroll view 
causes the proper sizeHints to be returned so the workaround to compute them 
is no longer needed and I have remove it.  

-Benjamin Meyer

-- 
aka icefox
Public Key: http://www.icefox.net/public_key.asc
[prev in list] [next in list] [prev in thread] [next in thread]