[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/kio/bookmarks
From:       Frerich Raabe <raabe () kde ! org>
Date:       2005-01-31 1:37:29
Message-ID: 20050131013729.8CE401A14E () office ! kde ! org
[Download RAW message or body]

CVS commit by raabe: 

- I suppose David knows this code better than I do, if he says this looks
  wrong chances are that it is wrong indeed.
CCMAIL:dfaure@kde.org


  M +3 -17     kbookmark.cc   1.122
  M +1 -1      kbookmark.h   1.60


--- kdelibs/kio/bookmarks/kbookmark.cc  #1.121:1.122
@@ -181,5 +181,5 @@ KBookmark KBookmarkGroup::addBookmark( K
 
     if (emitSignal) {
-        if ( bm.hasExtraMetaData() ) {
+        if ( bm.hasMetaData() ) {
             mgr->notifyCompleteChange( "" );
         } else {
@@ -403,23 +403,9 @@ static QDomNode findOrCreateMetadata( QD
 }
 
-bool KBookmark::hasExtraMetaData() const
+bool KBookmark::hasMetaData() const
 {
-    static const QString &timeAdded = KGlobal::staticQString( "time_added" );
-    static const QString &timeVisited = KGlobal::staticQString( "time_visited" );
-    static const QString &visitCount = KGlobal::staticQString( "visit_count" );
-
     QDomNode n = cd_or_create( internalElement(), "info" );
     n = findOrCreateMetadata( n );
-    for ( n = n.firstChild(); !n.isNull(); n = n.nextSibling() ) {
-        if ( !n.isElement() ) {
-            continue;
-        }
-        const QString tagName = n.toElement().tagName();
-        if ( tagName != timeAdded && tagName != timeVisited && tagName != visitCount ) {
-            return true;
-        }
-    }
-
-    return false;
+    return !n.firstChild().isNull();
 }
 

--- kdelibs/kio/bookmarks/kbookmark.h  #1.59:1.60
@@ -183,5 +183,5 @@ protected:
 
 private:
-    bool hasExtraMetaData() const;
+    bool hasMetaData() const;
 };
 


[prev in list] [next in list] [prev in thread] [next in thread]