[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio/bookmarks
From:       David Faure <faure () kde ! org>
Date:       2005-01-31 1:19:41
Message-ID: 200501310219.41916.faure () kde ! org
[Download RAW message or body]


> +bool KBookmark::hasExtraMetaData() const
> +{
> +    static const QString &timeAdded = KGlobal::staticQString( "time_added" );
> +    static const QString &timeVisited = KGlobal::staticQString( "time_visited" );
> +    static const QString &visitCount = KGlobal::staticQString( "visit_count" );
> +
> +    QDomNode n = cd_or_create( internalElement(), "info" );
> +    n = findOrCreateMetadata( n );
> +    for ( n = n.firstChild(); !n.isNull(); n = n.nextSibling() ) {
> +        if ( !n.isElement() ) {
> +            continue;
> +        }
> +        const QString tagName = n.toElement().tagName();
> +        if ( tagName != timeAdded && tagName != timeVisited && tagName != visitCount ) {
> +            return true;
> +        }
> +    }
> +
> +    return false;
> +}

You're not giving me much time to object, are you? :)

The above looks wrong to me - hasExtraMetaData should be generic (any <metadata>),
not tied to those three particular metadata entries.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]