[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kwin
From:       Luboš Luňák <l.lunak () kde ! org>
Date:       2005-01-27 14:21:31
Message-ID: 20050127142131.E6A581BABD () office ! kde ! org
[Download RAW message or body]

CVS commit by lunakl: 

Giving up on #78082, at least temporarily. Don't force using placement
policy for dialogs if they request a specific geometry. Too bad apps
always specify geometry for dialogs, so if they specify silly positions
like under mouse or centered on the screen the only solution for now
is choosing ignoring requested position in window-specific settings.
BUG: 78082


  M +12 -0     manage.cpp   2.70


--- kdebase/kwin/manage.cpp  #2.69:2.70
@@ -229,5 +229,17 @@ bool Client::manage( Window w, bool isMa
         {
         if( mainClients().count() >= 1 )
+            {
+#if 1
+            // TODO #78082 - Ok, it seems there are after all some cases when an application has a good
+            // reason to specify a position for its dialog. Too bad other WMs have never bothered
+            // with placement for dialogs, so apps always specify positions for their dialogs,
+            // including such silly positions like always centered on the screen or under mouse.
+            // Using ignoring requested position in window-specific settings helps, but at least
+            // for Qt apps this should work better.
+            usePosition = true;
+#else
             ; // force using placement policy
+#endif
+            }
         else
             usePosition = true;


[prev in list] [next in list] [prev in thread] [next in thread]