[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kmdi
From:       David Faure <faure () kde ! org>
Date:       2005-01-26 18:22:30
Message-ID: 200501261922.31142.faure () kde ! org
[Download RAW message or body]

On Wednesday 26 January 2005 19:20, Andras Mantia wrote:
> On Wednesday 26 January 2005 20:01, David Faure wrote:
> > On Wednesday 26 January 2005 18:59, Andras Mantia wrote:
> > > I'm wondering if KTabWidget from CVS HEAD is binary compatible with
> > > the one from 3.3. In 3.3 the insertTab methods are not overridden,
> > > while in CVS HEAD they are, altough they are virtual methods of
> > > QTabWidget...
> >
> > That's BC, see the BC paper on developer.kde.org.
> 
> It's so hard to find that document (I usually can find only through the 
> developer checklist page).

Alt F2, ggl:binary compatibility site:developer.kde.org
:)

> You're right, I forgot the following  
> statement:
> "reimplement virtual functions defined in one of the base classes if it 
> is safe that programs linked with the prior version of the library call 
> the implementation in the base class rather than the new one.  This is 
> tricky and might be dangerous. Think twice before doing it.  "
>  
> I don't know if it's dangerous in this case or not, but unfortunately 
> the current way broke the kdelibs's compilation. Maybe in this case all 
> variants of the method should be reimplemented, even if you want to 
> reimplement only one?

Ah - due to virtual method hiding? Yes, all overloads must be reimplemented.
(We can't use the "using ..." keyword, it breaks with gcc-2.95)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]