[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror
From:       George Staikos <staikos () kde ! org>
Date:       2005-01-24 19:39:12
Message-ID: 200501241439.12825.staikos () kde ! org
[Download RAW message or body]

On Monday 24 January 2005 14:34, Daniel Teske wrote:
>  > And there's no MI that could interfere in this case?
>
> Alot of code relies on that, just search for "Tabs" in konq_viewmgr.cc.
> So I assumed that it is okay, I haven't checked that.
> Now that you mention it, KonqFrameTabs is derived of:
>
> KTabWidget and KonqFrameContainerBase.
>
> Hmm, I have to look up the details, but these static_cast<> look wrong to
> me.

  Yeah it might need a review again.  This code has been problematic ever 
since KDE 2.0 with using the wrong type of cast, or using dynamic_cast and 
not checking for null.   There have been endless bugs and regressions due to 
this.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
[prev in list] [next in list] [prev in thread] [next in thread]