[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror
From:       George Staikos <staikos () kde ! org>
Date:       2005-01-24 19:10:53
Message-ID: 200501241410.53297.staikos () kde ! org
[Download RAW message or body]

On Monday 24 January 2005 14:07, Daniel Teske wrote:
> >>+  if( mainWindow->childFrame() &&  mainWindow->childFrame()->frameType()
> >>== "Tabs") +  {
> >>+    KonqFrameTabs *kft = dynamic_cast<KonqFrameTabs
> >>*>(mainWindow->childFrame()); +    if(kft->childFrameList()->count())
> >>+      kft->childFrameList()->at(0)->copyHistory( currentFrame );
> >>+  }
> >
> >   You need to check kft for null too.  dynamic_cast<> could fail.
>
> The dynmaic_cast<> can't fail, because the frameType() is "Tabs".
> I should have used static_cast<> instead, will fix that.

  And there's no MI that could interfere in this case?

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
[prev in list] [next in list] [prev in thread] [next in thread]