[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror
From:       George Staikos <staikos () kde ! org>
Date:       2005-01-24 18:56:55
Message-ID: 200501241356.55663.staikos () kde ! org
[Download RAW message or body]

On Monday 24 January 2005 13:43, Daniel Teske wrote:
> --- kdebase/konqueror/konq_viewmgr.cc  #1.277:1.278
> @@ -497,4 +497,5 @@ void KonqViewManager::breakOffTab( KonqF
>    config.writeEntry( "RootItem", prefix );
>    prefix.append( '_' );
> +  config.writeEntry( QString::fromLatin1( "docContainer" ).prepend( prefix
> ), true ); currentFrame->saveConfig( &config, prefix, true, 0L, 0, 1);
>
> @@ -504,8 +505,10 @@ void KonqViewManager::breakOffTab( KonqF
>    mainWindow->viewManager()->loadViewProfile( config, "" );
>
> -  mainWindow->viewManager()->setDocContainer( mainWindow->childFrame() );
> -
> -  if (mainWindow->currentView())
> -    mainWindow->copyHistory( currentFrame );
> +  if( mainWindow->childFrame() &&  mainWindow->childFrame()->frameType()
> == "Tabs") +  {
> +    KonqFrameTabs *kft = dynamic_cast<KonqFrameTabs
> *>(mainWindow->childFrame()); +    if(kft->childFrameList()->count())
> +      kft->childFrameList()->at(0)->copyHistory( currentFrame );
> +  }

   You need to check kft for null too.  dynamic_cast<> could fail.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
[prev in list] [next in list] [prev in thread] [next in thread]