[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/dcop
From:       Stephan Kulow <coolo () kde ! org>
Date:       2005-01-20 10:46:12
Message-ID: 200501201146.13113.coolo () kde ! org
[Download RAW message or body]

Am Thursday 20 January 2005 11:16 schrieb Dirk Mueller:
> On Thursday 20 January 2005 11:13, Stephan Kulow wrote:
> 
> > always init builtin types before using them (even for doing nothing). This
> > way gcc doesn't complain we would use an unintialized bool to check it's
> > type name CCMAIL: matz@suse.de
> 
> why are you working around gcc 4.0 CVS bugs ?
Because it doesn't hurt in any case. Either the init is an empty function anyway
or is a statement that will be optimized out anyway as followed by a real assignment.

As our security team decided that it's a good idea to get rid of all uninitialized
variables, we use gcc4 for code review. In this very case, it's argueable if it's a bug
in the compiler. And as I said, the code change doesn't harm, I would prefer having
kde code removed from the "possibly insecure" list.

Greetings, Stephan
[prev in list] [next in list] [prev in thread] [next in thread]