[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml/html
From:       Allan Sandfeld Jensen <kde () carewolf ! com>
Date:       2005-01-17 10:41:26
Message-ID: 200501171141.26504.kde () carewolf ! com
[Download RAW message or body]

On Monday 17 January 2005 11:29, Dirk Mueller wrote:
> On Monday 17 January 2005 11:23, Allan Sandfeld Jensen wrote:
> > -            else if ( beginTag && !brokenScript && tagID == ID_SCRIPT )
> > { +            else if ( !brokenScript && tagID == ID_SCRIPT ) {
> >                  DOMStringImpl* a = 0;
> >                  bool foundTypeAttribute = false;
>
> eeehmm.. attributes on close tags shouldn't be evaluated. This code change
> is wrong.
>
> > +                else if (tagID < ID_CLOSE_TAG) // Handle <script
> > src="foo"/> +                    scriptHandler();
>
> only if its a compact tag.
>
Right. It is for compatibility with Mozilla and Opera, and ported from 
WebCore. They have this comment:

// This is a deliberate quirk to match Mozilla and Opera.  We have to do this
// since sites that use the "standards-compliant" path sometimes send
// <script src="foo.js"/>.  Both Moz and Opera will honor this, despite it
// being bogus HTML.  They do not honor the "/" for other tags.  This behavior
// also deviates from WinIE, but in this case we'll just copy Moz and Opera.

`Allan
[prev in list] [next in list] [prev in thread] [next in thread]