[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kwin [POSSIBLY UNSAFE]
From:       Stephan Binner <binner () kde ! org>
Date:       2005-01-15 20:27:54
Message-ID: 200501152128.02344.binner () kde ! org
[Download RAW message or body]

On Saturday 15 January 2005 18:07, Thomas Lübking wrote:

> Added composite (translucency/shadows) support

So much place for "improvements":

| if (QMessageBox::warning(0, i18n("Failed to start kompmgr - KWin"),
| i18n("The Composite Manager could not be started.<br>Make sure you've got
| \"kompmgr\" in a $PATH directory"), "OK", "Don't try again") == 1)  

- Please read [1] about capitalization rules for captions/buttons/checkboxes
- The caption shouldn't add "- KWin"
- The text misses <qt></qt> enclosings
- The button texts are not translatable
- We give "OK" buttons an accel/use KStdGuiItem/use proper dialogs
- Give a parent for the dialog
- Finally we have KMessageBox with proper dontaskagain support

| QGridLayout *gLay = new QGridLayout(vLay,4,2);

KDialog::marginHint(), KDialog::spacingHint() ?

| activeWindowTransparency = new QCheckBox(i18n("Active Windows"),tGroup);

Wrong checkboxes capitalization style.

| QMessageBox::information(0, i18n("Warning"), i18n("Translucency support is 

KMessageBox::information()

| M +305 -180  kcmkwin/kwinrules/ruleswidgetbase.ui   1.18

Please run fixuifiles from kdesdk before committing .ui files.

Bye,
   Steve

[1] 
http://developer.kde.org/documentation/standards/kde/style/basics/labels.html

[prev in list] [next in list] [prev in thread] [next in thread]