[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs
From:       David Faure <faure () kde ! org>
Date:       2005-01-08 22:04:53
Message-ID: 200501082304.54284.faure () kde ! org
[Download RAW message or body]

On Saturday 08 January 2005 20:38, Benjamin Meyer wrote:
> CVS commit by bmeyer: 
> 
> clarified the Private * item with some more information
> 
> 
> M +1 -1      TODO   1.50
> 
> 
> --- kdelibs/TODO  #1.49:1.50
> @@ -3,5 +3,5 @@
> 
> - Change all FooPrivate *d; -> FooPrivate * const d; and place initialization
> -in constructor.  To help catch silly mistakes sense d should never change.
> +in constructor (for classes that would benefit 
> this).  To help catch silly mistakes sense d should never change. 
> Also concider changing to use KStaticDeleter to help prvent mistakes where \
> developers forget to delete the pointer.    

Well KStaticDeleter is for static instances only, it can't be used when 
there are multiple instances of a class, and it doesn't help "not forgetting"
anyway, since one has to remember using KStaticDeleter in the first place....
This suggestion makes no sense to me.
Maybe you meant auto_ptr<>?

PS: You could have fixed s/sense/since/ while being at it :)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


[prev in list] [next in list] [prev in thread] [next in thread]