[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdepim/kioslaves/imap4
From:       Till Adam <adam () kde ! org>
Date:       2004-12-31 23:11:59
Message-ID: 20041231231159.3968D1B8D4 () office ! kde ! org
[Download RAW message or body]

CVS commit by tilladam: 

Reduce the timeout value from 10 minutes to 1 minute which seems 
alltogether more reasonable. This makes KMail time out much faster after
IP changes, for example, and 1 minute should be plenty forany kind of
latency on the internet today, although very busy servers might time out
more often with this. Still, I think keeping this lower is preferrable, as
the "hanging" KMail is quite a nuissance with flakey (wlan) connections.

Carsten, I hope you forgive me comitting this without prior consent from 
you. Feel free to revert should this hurt your feelings. 

Happy New Year, everyone : )


  M +3 -2      imap4.cc   1.199


--- kdepim/kioslaves/imap4/imap4.cc  #1.198:1.199
@@ -88,4 +88,5 @@ extern "C" {
 #define IMAP_PROTOCOL "imap"
 #define IMAP_SSL_PROTOCOL "imaps"
+#define IMAP_TIMEOUT_IN_SECONDS 60
 
 using namespace KIO;
@@ -740,5 +741,5 @@ bool IMAP4Protocol::parseReadLine (QByte
       return FALSE;
     }
-    if (!waitForResponse(600))
+    if (!waitForResponse( IMAP_TIMEOUT_IN_SECONDS ))
     {
       error(ERR_SERVER_TIMEOUT, myHost);
@@ -2360,5 +2361,5 @@ ssize_t IMAP4Protocol::myRead(void *data
   }
   if (!isConnectionValid()) return 0;
-  waitForResponse(600);
+  waitForResponse( IMAP_TIMEOUT_IN_SECONDS );
   return read(data, len);
 }


[prev in list] [next in list] [prev in thread] [next in thread]