[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeaddons/atlantikdesigner/designer
From:       Matt Rogers <mattr () kde ! org>
Date:       2004-12-29 14:30:42
Message-ID: 200412290830.43087.mattr () kde ! org
[Download RAW message or body]

On Wednesday 29 December 2004 02:03 am, Helge Deller wrote:
> CVS commit by deller:
>
> fix build by adding $(KDE_DIR)/atlantic include path (find
> libatlantic_export.h)
>
>
>   M +1 -1      Makefile.am   1.8
>
>
> --- kdeaddons/atlantikdesigner/designer/Makefile.am  #1.7:1.8
> @@ -1,4 +1,4 @@
>  bin_PROGRAMS = atlantikdesigner
> -INCLUDES = $(all_includes)
> +INCLUDES = $(KDE_INCLUDES)/atlantic $(all_includes)
>  AM_LDFLAGS = $(all_libraries) $(KDE_RPATH)
>  LDADD = -latlantikui -lkdegames $(LIB_KIO)

This seems wrong to me. Shouldn't $(KDE_INCLUDES)/atlantic point to somewhere 
in the builddir instead? (assuming of course that libatlantic_export.h is 
autogenerated)

Matt
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic