[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror/listview
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2004-12-25 10:02:46
Message-ID: 20041225100245.GA23518 () ktown ! kde ! org
[Download RAW message or body]

On Fri, Dec 24, 2004 at 04:12:58PM +0100, David Faure wrote:
> On Friday 24 December 2004 16:00, Martin Koller wrote:
> > CVS commit by mkoller: 
> > 
> > Ensure that a plugin already has the widget defined
> > +   setInstance( KonqListViewFactory::instance() );
> > +   setXMLFile( xmlFile );
> 
> I just realized the risk of moving down the setInstance call: 
> any i18n() before that line won't work, since setInstance loads the i18n catalogue
> for the part.
> 
> Sounds like a general KParts design mistake: we say that setInstance should be 
> done first (in the part's constructor) for the i18n catalogues, but at the same time
> it should be done last for the plugins (so that the view is already created).
> 
> Simon: do you think we should remove the automatic loading of plugins from
> setInstance in KDE4, and tell people to add a mandatory loadPlugins() call at the 
> end of the part constructor instead?
> 
> A typical part ctor would then be
> 
> setInstance(...);
> setWidget(...);
> setXMLFile(...);
> create actions etc.
> loadPlugins();

I agree. I don't think there are so many applications loading
plugins anyway that the automatic loading is really worth it, while
on the other hand with a explicit loadPlugins() call it's clear from
reading that the application may have plugins.

Simon
[prev in list] [next in list] [prev in thread] [next in thread]